[Yoav]

Hi there,

It’s no biggies but it should be fixed on all themes. Search Input element does not have associated labels.

Read on: https://web.dev/label/

[Bob]

Hi Yoav,

In cases where the label breaks styles or when we use only search icon, instead of a label, we can add the aria-label to the search input and if I remember well almost in all themes I used this attribute.

--
Do you appreciate the support you've received today? If so, consider donating to the Publii team by clicking here; we'll be sure to use your donation to make Publii even better!

[Yoav]

Yeah, I think the aria-label should improve the overall score. The Documentation theme doesn’t have it.

[Bob]

It has, and the lighthouse does not show any issue with that.

--
Do you appreciate the support you've received today? If so, consider donating to the Publii team by clicking here; we'll be sure to use your donation to make Publii even better!

[Yoav]

Weird, I cannot see it the latest version (1.4.0.0) for some reasons, even after looking in the .hbs files to be certain.

[Bob]

What search engine do you use, Google or DocSearch?

--
Do you appreciate the support you've received today? If so, consider donating to the Publii team by clicking here; we'll be sure to use your donation to make Publii even better!

[Yoav]

Google’s Custom Search. I do see the tag it for Algolia indeed.

Edit: I’ve also found another, bigger, problem: https://forum.getpublii.com/topic/amp-validation-errors/

[Bob]

Yeap, I forgot to add the aria-label to the Google search input, will do it the next theme release.

--
Do you appreciate the support you've received today? If so, consider donating to the Publii team by clicking here; we'll be sure to use your donation to make Publii even better!

[Yoav]

Yeah, no worries. Thanks 🙂

Can we have also a look at: https://forum.getpublii.com/topic/amp-validation-errors/

[Bob]

Yoav wrote:

Can we have also a look at: https://forum.getpublii.com/topic/amp-validation-errors/

Yes, but the fix must be applied to the app, so I wouldn’t expect it too soon.

--
Do you appreciate the support you've received today? If so, consider donating to the Publii team by clicking here; we'll be sure to use your donation to make Publii even better!

[Author]

Posts