Search input label is missing
- This topic has 9 replies, 2 voices, and was last updated 1 year, 4 months ago by .
- May 28, 2020 at 6:23 am #2818Yoav
It’s no biggies but it should be fixed on all themes. Search Input element does not have associated labels.
Read on: https://web.dev/label/May 28, 2020 at 7:02 am #2819Bob
In cases where the label breaks styles or when we use only search icon, instead of a label, we can add the aria-label to the search input and if I remember well almost in all themes I used this attribute.May 28, 2020 at 7:10 am #2820Yoav
Yeah, I think the aria-label should improve the overall score. The Documentation theme doesn’t have it.May 28, 2020 at 7:16 am #2822Bob
It has, and the lighthouse does not show any issue with that.May 28, 2020 at 7:21 am #2824Yoav
Weird, I cannot see it the latest version (184.108.40.206) for some reasons, even after looking in the .hbs files to be certain.May 28, 2020 at 7:23 am #2825Bob
What search engine do you use, Google or DocSearch?May 28, 2020 at 7:25 am #2826Yoav
Google’s Custom Search. I do see the tag it for Algolia indeed.
Edit: I’ve also found another, bigger, problem: https://forum.getpublii.com/topic/amp-validation-errors/May 28, 2020 at 7:29 am #2827Bob
Yeap, I forgot to add the aria-label to the Google search input, will do it the next theme release.May 28, 2020 at 7:31 am #2828Yoav
Yeah, no worries. Thanks 🙂
Can we have also a look at: https://forum.getpublii.com/topic/amp-validation-errors/May 28, 2020 at 7:48 am #2829Bob
Can we have also a look at: https://forum.getpublii.com/topic/amp-validation-errors/
Yes, but the fix must be applied to the app, so I wouldn’t expect it too soon.
- The topic ‘Search input label is missing’ is closed to new replies.